ignore cmake/ directory in bazel source file checks#2936
Merged
Conversation
kilograham
changed the title
will-v-pi
reviewed
May 15, 2026
Contributor
will-v-pi
left a comment
will-v-pi
left a comment
There was a problem hiding this comment.
This doesn't fix the issue you're seeing in #2921 - you also need to change git_ls_files_by_extension to only return files in these paths.
Also, it's not just files under src and test that should be checked, it should also check tools/pioasm, so I think excluding cmake is possibly the better option than explicitly specifying paths to search?
A fix could be to revert this change and just add
bazel_files = [f for f in bazel_files if not f.is_relative_to("cmake")]before return bazel_files in git_ls_files_by_extension, to exclude the files under cmake
kilograham
force-pushed
the
relax-bazel-check
branch
from
260baf0 to
53ce06f
Compare
kilograham
changed the title
Contributor
Author
|
i have force pushed your change. if you are feeling keen @will-v-pi can you fix it to not complain if you have board definitions headers which aren't checked it ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @armandomontanez